Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/Add breaking changes warning #2039 #2092

Merged
merged 9 commits into from
Nov 21, 2023
Merged

Feature/Add breaking changes warning #2039 #2092

merged 9 commits into from
Nov 21, 2023

Conversation

siepra
Copy link
Contributor

@siepra siepra commented Nov 20, 2023

Pull Request Checklist

  • I have linked this PR to related GitHub issue.
  • I have updated the CHANGELOG.md file with relevant changes (the file is located at the root of monorepo).

(Optional) Mobile checklist

Please ensure you completed the following checks if you did any changes to the mobile package:

  • I have run e2e tests for mobile
  • I have updated base screenshots for visual regression tests

Description

Solves #2039

I made UpdateModalComponent reusable by opening a way to dynamically set its contents (title, message and buttons). I also changed its name suffixing it with keyword to distinguish from corresponding container.

@siepra
Copy link
Contributor Author

siepra commented Nov 20, 2023

Nagranie.z.ekranu.2023-11-20.o.16.26.52.mov
Nagranie.z.ekranu.2023-11-20.o.16.27.48.mov

@siepra siepra changed the title Feature/2039 Feature/Add breaking changes warning #2039 Nov 21, 2023
@siepra siepra merged commit 97e1804 into master Nov 21, 2023
10 of 14 checks passed
@siepra siepra deleted the feature/2039 branch November 21, 2023 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants