Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use notarytool for macos notarization #2008

Merged
merged 1 commit into from
Oct 26, 2023
Merged

use notarytool for macos notarization #2008

merged 1 commit into from
Oct 26, 2023

Conversation

vinkabuki
Copy link
Contributor

Pull Request Checklist

  • I have linked this PR to related GitHub issue.
  • I have updated the CHANGELOG.md file with relevant changes (the file is located at the root of monorepo).

(Optional) Mobile checklist

Please ensure you completed the following checks if you did any changes to the mobile package:

  • I have run e2e tests for mobile
  • I have updated base screenshots for visual regression tests

@vinkabuki vinkabuki mentioned this pull request Oct 26, 2023
Closed
Kacper-RF
Kacper-RF approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@Kacper-RF Kacper-RF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vinkabuki vinkabuki merged commit c1f7e27 into master Oct 26, 2023
11 of 14 checks passed
@siepra siepra deleted the chore/use-notarytool-on-macos branch December 8, 2023 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kacper-RF Kacper-RF Kacper-RF approved these changes

@siepra siepra siepra approved these changes

@EmiM EmiM Awaiting requested review from EmiM

@leblowl leblowl Awaiting requested review from leblowl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vinkabuki @siepra @Kacper-RF