Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/Registered usernames that are duplicates or invalid should trigger aggressive warning modal #1831

Merged
merged 20 commits into from
Oct 5, 2023
Merged

feature/Registered usernames that are duplicates or invalid should trigger aggressive warning modal #1831

merged 20 commits into from
Oct 5, 2023

Conversation

Kacper-RF
Copy link
Contributor

@Kacper-RF Kacper-RF commented Sep 19, 2023 •
edited
Loading

Pull Request Checklist

  • I have linked this PR to related GitHub issue.
  • I have updated the CHANGELOG.md file with relevant changes (the file is located at the root of monorepo).

@Kacper-RF Kacper-RF marked this pull request as ready for review September 19, 2023 11:37
leblowl
leblowl approved these changes Sep 19, 2023
View reviewed changes
Copy link
Collaborator

@leblowl leblowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Perhaps squashing changes before merging could be a good idea to keep the git commit history easy to read on develop.

...sktop/src/renderer/components/widgets/aggressiveWarningModal/AggressiveWarningModal.test.tsx Outdated Show resolved Hide resolved
@leblowl
Copy link
Collaborator

leblowl commented Sep 19, 2023

Might be good to get a quick review from @siepra also

siepra
siepra approved these changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@siepra siepra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally I'd want desktop and mobile changes to be done in separate pull requests

@siepra
Copy link
Contributor

siepra commented Sep 26, 2023

It just came to me, the name "AgressiveWarning" is a little bit odd. It doesn't really tell what's going on. I think something like "DuplicatedUsernameWarning" would be more accurate

@Kacper-RF
Copy link
Contributor Author

We already have something similar as DuplicatedUsernameWarning so nomenclature was changed to - PossibleImpersonationAttack (just like the title on the designs in Figma).

@Kacper-RF Kacper-RF mentioned this pull request Oct 2, 2023
Closed
@siepra
Copy link
Contributor

siepra commented Oct 2, 2023

I wish there were RTL and RNTL tests for displaying the modal. Also I know this is inconvenient but there should be a base screenshot for mobile visual regressions tests uploaded. Until we have a dedicated GitHub runner I can help you with running those tests.

@Kacper-RF Kacper-RF merged commit d6242b9 into develop Oct 5, 2023
18 of 19 checks passed
@siepra siepra deleted the feature/119 branch October 6, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leblowl leblowl leblowl approved these changes

@siepra siepra siepra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kacper-RF @leblowl @siepra