Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore/e2e test unregistered user #1826

Merged
merged 25 commits into from
Oct 5, 2023
Merged

Chore/e2e test unregistered user #1826

merged 25 commits into from
Oct 5, 2023

Conversation

EmiM
Copy link
Collaborator

@EmiM EmiM commented Sep 18, 2023 •
edited
Loading

Pull Request Checklist

  • I have linked this PR to related GitHub issue.
  • I have updated the CHANGELOG.md file with relevant changes (the file is located at the root of monorepo).

@EmiM EmiM mentioned this pull request Sep 19, 2023
Closed
@EmiM EmiM marked this pull request as ready for review September 25, 2023 11:45
@EmiM EmiM requested review from vinkabuki and Kacper-RF and removed request for vinkabuki September 25, 2023 12:44
leblowl
leblowl reviewed Sep 27, 2023
View reviewed changes
Copy link
Collaborator

@leblowl leblowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

idea: perhaps squash commits to keep git history cleaner on develop

packages/e2e-tests/src/selectors.ts Show resolved Hide resolved
@EmiM EmiM merged commit c23826e into develop Oct 5, 2023
23 of 26 checks passed
@siepra siepra deleted the chore/e2e-test-unregistered-user branch December 8, 2023 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leblowl leblowl leblowl left review comments

@Kacper-RF Kacper-RF Kacper-RF approved these changes

@vinkabuki vinkabuki Awaiting requested review from vinkabuki

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@EmiM @leblowl @Kacper-RF