Bug/Deleting general channel does't work consistently #1525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Kacper-RF
commented
May 15, 2023
•
Kacper-RF
commented
- Use channel.address as main unique id in state manager package
- Use channel.address as main unique id in desktop package
- Fix State Manager tests
- Fix Backend unit tests
- Fix RTL tests
- Fix E2E tests
- Fix Desktop tests
- Use channel.address as main unique id in mobile package
- Fix Mobile unit tests
- Fix Mobile detox tests - https://app.bitrise.io/build/cf38a67e-a2f0-4cd4-9530-e5e24d63f196
- Change channel.address to channel.id
- E2E test - correct channel replication after removal in user's absence
- State transform - convert address to id
- Merge develop and resolve conflicts
…sages data structures
EmiM
reviewed
May 24, 2023
EmiM
reviewed
May 24, 2023
EmiM
reviewed
May 24, 2023
packages/desktop/src/renderer/sagas/notifications/notifications.saga.ts
Outdated
Show resolved
Hide resolved
EmiM
reviewed
May 24, 2023
EmiM
reviewed
May 24, 2023
siepra
reviewed
May 24, 2023
siepra
reviewed
May 24, 2023
packages/mobile/src/screens/CreateChannel/CreateChannel.screen.tsx
Outdated
Show resolved
Hide resolved
siepra
reviewed
May 24, 2023
EmiM
reviewed
May 24, 2023
...anager/src/sagas/publicChannels/channelDeletionResponse/channelDeletionResponse.saga.test.ts
Outdated
Show resolved
Hide resolved
siepra
reviewed
May 24, 2023
packages/mobile/src/screens/DeleteChannel/DeleteChannel.screen.tsx
Outdated
Show resolved
Hide resolved
siepra
reviewed
May 24, 2023
packages/mobile/src/screens/DeleteChannel/DeleteChannel.screen.tsx
Outdated
Show resolved
Hide resolved
EmiM
reviewed
May 24, 2023
...ate-manager/src/sagas/publicChannels/channelDeletionResponse/channelDeletionResponse.saga.ts
Show resolved
Hide resolved
EmiM
requested changes
May 24, 2023
packages/state-manager/src/sagas/publicChannels/channelsReplicated/channelsReplicated.saga.ts
Outdated
Show resolved
Hide resolved
packages/state-manager/src/sagas/publicChannels/publicChannels.selectors.ts
Outdated
Show resolved
Hide resolved
EmiM
approved these changes
May 24, 2023
siepra
approved these changes
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.