Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/e2e invitation link test for mac #1460

Merged
merged 6 commits into from
Apr 19, 2023

Conversation

EmiM
Copy link
Contributor

@EmiM EmiM commented Apr 18, 2023

No description provided.

* Close one app during test so macos has only one instance of the app opened while clicking on a link
* Manually save redux state during test (selenium clicks on the app too fast and state is not saved properly)
@EmiM EmiM force-pushed the fix/e2e-invitation-link-test-for-mac branch from 85b7557 to ac39c69 Compare April 18, 2023 16:19
@EmiM EmiM requested review from siepra and Kacper-RF and removed request for siepra April 18, 2023 16:27
Copy link
Contributor

@Kacper-RF Kacper-RF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EmiM EmiM merged commit e32d1b4 into develop Apr 19, 2023
@siepra siepra deleted the fix/e2e-invitation-link-test-for-mac branch April 24, 2023 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants