Channel deletion #1444
Merged
Channel deletion #1444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to feature/delete-channel
…to feature/delete-channel
…message about channel deletion
…st for ownerNickname
* Make channel tiles swipeable * Add DeleteChannel component * Add channel deletion screen * Attach channel deletion action * Fix mobile typings and tests * Remove call for clearing invitation code * Lint * Use state-managers delete action * Restore invitaion code handling in sm * Fix saga test for handling invitation code * Fix RTL tests
…ze e2e tests, fix mention in message
siepra
commented
Apr 26, 2023
siepra
commented
Apr 26, 2023
siepra
commented
Apr 26, 2023
siepra
commented
Apr 26, 2023
siepra
commented
Apr 26, 2023
packages/state-manager/src/sagas/publicChannels/deletedChannel/deletedChannel.saga.test.ts
Outdated
Show resolved
Hide resolved
siepra
commented
Apr 26, 2023
There was a problem hiding this comment.
It may be minor but I wish this saga was divided into two separate sagas: one for clearing up the store and second for sending owner's notification to general channel. It's all about limiting the responsibility of a single saga.
Also 'deletedChannel' might not be the right name... I'm thinking about something like 'channelDeletionResponseSaga' - to make it obvious that this should trigger after the channel has been deleted by backend
There was a problem hiding this comment.
I will do that in next PR
siepra
commented
Apr 26, 2023
packages/state-manager/src/sagas/publicChannels/publicChannels.slice.ts
Outdated
Show resolved
Hide resolved
vinkabuki
approved these changes
Apr 26, 2023
vinkabuki
approved these changes
Apr 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.