-
-
Notifications
You must be signed in to change notification settings - Fork 11k
Include entries in pt-BR in ghost.json #24785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughThis change updates Brazilian Portuguese translations in ghost/i18n/locales/pt-BR/ghost.json. Several previously empty translation values are populated for existing keys related to sign-in links, direct login, “Sign in now,” and a 24-hour validity message including {siteTitle}. No keys were added or removed; only values were modified. Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
ghost/i18n/locales/pt-BR/ghost.json (2)
35-36
: Minor phrasing/consistency tweaks: drop comma after “Ou” and prefer “entrar”Improves flow and aligns with other “Entrar” strings in this file.
- "Or use this link to securely sign in": "Ou use este link para acessar com segurança", - "Or, skip the code and log in directly": "Ou, ignore o código e entre diretamente", + "Or use this link to securely sign in": "Ou use este link para entrar com segurança", + "Or, skip the code and log in directly": "Ou ignore o código e entre diretamente",
64-64
: Optional consistency with Line 63 greetingLine 63 uses “Bem-vindo de volta...”. Consider matching that phrasing for consistency across emails.
- "Welcome back! Here's your code to sign in to {siteTitle}. For your security, it's valid for 24 hours": "Bem-vindo novamente! Aqui está seu código para entrar no site {siteTitle}. Para sua segurança, ele é válido por 24 horas", + "Welcome back! Here's your code to sign in to {siteTitle}. For your security, it's valid for 24 hours": "Bem-vindo de volta! Aqui está seu código para entrar no site {siteTitle}. Para sua segurança, ele é válido por 24 horas",
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
ghost/i18n/locales/pt-BR/ghost.json
(3 hunks)
🧰 Additional context used
🧠 Learnings (3)
📓 Common learnings
Learnt from: cathysarisky
PR: TryGhost/Ghost#0
File: :0-0
Timestamp: 2025-05-20T21:08:21.026Z
Learning: In the Ghost project, translation files (ghost/i18n/locales/*/*.json) commonly have blank values for translations, and this is normal behavior that should not be flagged in reviews. These empty translations will be filled in separate PRs.
Learnt from: cathysarisky
PR: TryGhost/Ghost#0
File: :0-0
Timestamp: 2025-01-29T15:27:29.391Z
Learning: When reviewing translation files in ghost/i18n/locales, translators should only modify the translated values and must not change the keys or placeholder styles (e.g., %%{status}%%, {site}, etc.) as they serve specific purposes like Mailgun string replacement.
Learnt from: cathysarisky
PR: TryGhost/Ghost#23070
File: ghost/i18n/locales/hu/comments.json:45-45
Timestamp: 2025-04-30T16:27:03.542Z
Learning: In the Ghost project, new translation string keys are intentionally added with empty values initially and will be translated in a separate PR. Do not report missing translations for entirely new string additions.
Learnt from: cathysarisky
PR: TryGhost/Ghost#22175
File: ghost/i18n/locales/pt-BR/portal.json:18-18
Timestamp: 2025-02-12T20:09:12.731Z
Learning: In the Ghost project, new translation keys are first added with empty string values, and the actual translations are added later in separate PRs to maintain better organization of translation work.
📚 Learning: 2025-05-20T21:08:21.026Z
Learnt from: cathysarisky
PR: TryGhost/Ghost#0
File: :0-0
Timestamp: 2025-05-20T21:08:21.026Z
Learning: In the Ghost project, translation files (ghost/i18n/locales/*/*.json) commonly have blank values for translations, and this is normal behavior that should not be flagged in reviews. These empty translations will be filled in separate PRs.
Applied to files:
ghost/i18n/locales/pt-BR/ghost.json
📚 Learning: 2025-01-29T15:27:29.391Z
Learnt from: cathysarisky
PR: TryGhost/Ghost#0
File: :0-0
Timestamp: 2025-01-29T15:27:29.391Z
Learning: When reviewing translation files in ghost/i18n/locales, translators should only modify the translated values and must not change the keys or placeholder styles (e.g., %%{status}%%, {site}, etc.) as they serve specific purposes like Mailgun string replacement.
Applied to files:
ghost/i18n/locales/pt-BR/ghost.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
- GitHub Check: Unit tests (Node 22.13.1)
- GitHub Check: Acceptance tests (Node 22.13.1, mysql8)
- GitHub Check: Legacy tests (Node 22.13.1, mysql8)
- GitHub Check: Acceptance tests (Node 22.13.1, sqlite3)
- GitHub Check: Legacy tests (Node 22.13.1, sqlite3)
- GitHub Check: E2E tests
- GitHub Check: Ghost-CLI tests
- GitHub Check: Lint
🔇 Additional comments (2)
ghost/i18n/locales/pt-BR/ghost.json (2)
4-4
: LGTM: natural phrasing and consistent with existing “link” usageNo placeholders involved; matches tone used elsewhere in pt-BR.
43-43
: LGTM: concise imperative matches UI toneTranslation is clear and idiomatic.
@Lekler @fthiesen New entries in Brazilian Portuguese.