-
-
Notifications
You must be signed in to change notification settings - Fork 11k
🎨 Allow longer strings in user dropdown menu #24743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
🎨 Allow longer strings in user dropdown menu #24743
Conversation
WalkthroughUpdated CSS in ghost/admin/app/styles/layouts/main.css to change the width of two selectors. The .gh-user-name and .gh-user-email rules were modified from a fixed width of 188px to a flexible width of 100%, altering how these elements occupy horizontal space within their container. Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
ghost/admin/app/styles/layouts/main.css (2)
368-378
: Avoid overlap with the absolute-positioned sign-out button; improve wrapping semanticsSetting width: 100% risks text flowing underneath the .user-menu-signout button (absolute at right:12px). Also, word-break: break-all hurts readability (especially for emails and CJK). Recommend reserving space for the button and using friendlier wrapping.
Apply this diff within the .gh-user-name block:
.gh-user-name { display: inline-block; - width: 100%; + /* Reserve space for the sign-out button; adjust if its hit-area changes */ + width: calc(100% - 56px); margin: 1px 0 0; padding: 0; - word-break: break-all; + /* Prefer readable breaking for long names/usernames */ + overflow-wrap: anywhere; + word-break: break-word; /* fallback */ + hyphens: auto; font-size: 1.5rem; letter-spacing: 0; font-weight: 500; line-height: 1; }Verification checklist:
- Open the account menu with a very long unbroken username and confirm there’s no overlap with the sign-out control at different zoom levels and breakpoints (>=1240px, 801-1239px, <=800px).
- Check LTR and RTL locales.
- Ensure the dropdown positioning (top: -324px on the menu) still looks correct when the header increases in height.
380-390
: Same concern for email; prefer readable wrapping and reserve space for actionsEmails broken “anywhere” are hard to read; also protect against overlap with the sign-out button like above.
Apply this diff within the .gh-user-email block:
.gh-user-email { display: inline-block; - width: 100%; + width: calc(100% - 56px); margin: 0; padding: 0; - word-break: break-all; + /* Preserve legibility for long email addresses */ + overflow-wrap: anywhere; + word-break: break-word; /* fallback */ + hyphens: auto; font-size: 1.3rem; font-weight: 400; line-height: 1; color: var(--middarkgrey); }Optional follow-up (if you prefer to keep width: 100%): add right padding on the containing .gh-user-info instead to make room for the button:
/* In .gh-account-menu-header .gh-user-info */ padding-right: 56px;Please verify visually with extreme-length emails (e.g., 120+ chars, long TLDs) across browsers (Chrome, Firefox, Safari).
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
ghost/admin/app/styles/layouts/main.css
(2 hunks)
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: kevinansfield
PR: TryGhost/Ghost#23824
File: ghost/core/core/server/services/email-service/email-templates/partials/styles.hbs:919-926
Timestamp: 2025-06-13T11:57:58.226Z
Learning: In `ghost/core/core/server/services/email-service/email-templates/partials/styles.hbs`, some style blocks (e.g., `.latest-post p` and `.latest-post p a`) still use the legacy colour `#73818c` on purpose; they are later overridden by `emailCustomization` feature rules, as noted by inline TODO comments. These occurrences should not be flagged as inconsistencies.
This PR makes it possible for longer strings in the user account dropdown that appears from the sidebar in Ghost Admin. The string width was capped at
188px
and this PR updates it to100%
.Before

After

This is my first OS contribution ever :).