Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added latest_event_timestamp to emails table #20118

Merged
merged 3 commits into from May 7, 2024

Conversation

ronaldlangeveld
Copy link
Member

@ronaldlangeveld ronaldlangeveld commented May 2, 2024

ref ENG-832

  • Added migrations for latest_event_timestamp column in emails table.
  • updated schema
  • updated emails model

ref ENG-832

- Added migrations for latest_event_timestamp column in emails table.
- updated schema
- updated emails model
@github-actions github-actions bot added the migration [pull request] Includes migration for review label May 2, 2024
Copy link
Contributor

github-actions bot commented May 2, 2024

It looks like this PR contains a migration 👀
Here's the checklist for reviewing migrations:

General requirements

  • Satisfies idempotency requirement (both up() and down())
  • Does not reference models
  • Filename is in the correct format (and correctly ordered)
  • Targets the next minor version
  • All code paths have appropriate log messages
  • Uses the correct utils
  • Contains a minimal changeset
  • Does not mix DDL/DML operations

Schema changes

  • Both schema change and related migration have been implemented
  • For index changes: has been performance tested for large tables
  • For new tables/columns: fields use the appropriate predefined field lengths
  • For new tables/columns: field names follow the appropriate conventions
  • Does not drop a non-alpha table outside of a major version

Data changes

  • Mass updates/inserts are batched appropriately
  • Does not loop over large tables/datasets
  • Defends against missing or invalid data
  • For settings updates: follows the appropriate guidelines

@ronaldlangeveld ronaldlangeveld changed the title Added latest-event-timestamp to emails table Added latest_event_timestamp to emails table May 2, 2024
@ronaldlangeveld ronaldlangeveld marked this pull request as ready for review May 2, 2024 06:17
Copy link
Contributor

@sagzy sagzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ronaldlangeveld ronaldlangeveld merged commit 3246a8d into main May 7, 2024
22 checks passed
@ronaldlangeveld ronaldlangeveld deleted the added-latest-event-timestamp-col branch May 7, 2024 08:12
ronaldlangeveld added a commit that referenced this pull request May 7, 2024
ronaldlangeveld added a commit that referenced this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
migration [pull request] Includes migration for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants