Improve messaging and error handling #20078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterzimon
force-pushed
the
update-toast-style
branch
2 times, most recently
from
14d6435
to
5de61bb
Compare
peterzimon
force-pushed
the
update-toast-style
branch
from
9bc2080
to
4138ddb
Compare
peterzimon
force-pushed
the
update-toast-style
branch
2 times, most recently
from
641724d
to
71233e0
Compare
- Toast messages in Settings were too generic, ie. not tailored for the given experience. This commit removes all unnecessary toasts and updates the messages to make more sense, be more consise and consistent with Ghost wording.
Instead of using toast to let people know about fields with error in a form, we show a "Retry" button. This aligns with the pattern we use elsewhere in Ghost and makes the UI less cluttered.
peterzimon
force-pushed
the
update-toast-style
branch
from
0f720fc
to
de1427f
Compare
peterzimon
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref DES-228
Toast messages in Ghost are way too unrefined and strong both in terms of style and copy. This PR updates the Toast component inside Settings to be more user friendly and to be shown only when necessary with improved copy.