Scripts/Quest: Update 'Guide Our Sights'

[offl]

Changes proposed:

• Update 'Guide Our Sights'

Issues addressed:

none

Tests performed:

builds, tested in-game

[Nyr97]

isn't it best to create a constexpr array with all of these and just loop it which keeps the order you're using?

[offl]

Imo that is making it overcomplicated

[offl]

The reason why I kept sniffed order is just because why not

[Nyr97]

I get that keeping the sniffed order makes sense visually or for matching behavior, but honestly, having 20+ repeated CastSpell calls clutters the code and makes it harder to maintain or verify. A constexpr array (or even just a static list) would keep the order intact while making the logic much clearer and future-proof.

Up to you anyway ^^

[offl]

I like making stuff simple, majority of Blizz scripts are simple
This script is quite simple as we just casted 20 spells using same function
Same in smaller versions of such spell scripts

    void HandleScript(SpellEffIndex /*effIndex*/)
    {
        Unit* caster = GetCaster();
        caster->CastSpell(caster, SPELL_BALLISTA_BOW);
        caster->CastSpell(caster, SPELL_BALLISTA_FRAME);
        caster->CastSpell(caster, SPELL_BALLISTA_MISSILE);
        caster->CastSpell(caster, SPELL_BALLISTA_WHEEL);
        caster->CastSpell(caster, SPELL_BALLISTA_WHEEL);
        caster->CastSpell(caster, SPELL_BALLISTA_WHEEL);
        caster->CastSpell(caster, SPELL_BALLISTA_WHEEL);
        caster->CastSpell(caster, SPELL_BALLISTA_KNOCKBACK);
    }

I understand that casting 20 spells may look weird but that is how it is scripted

[Nyr97]

Oh no, the idea was to make the code look better, plain as it is.