Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core/Disables: Added DISABLE_TYPE_PHASE_AREA #29997

Merged
merged 2 commits into from
Jun 3, 2024

Conversation

mdX7
Copy link
Member

@mdX7 mdX7 commented May 21, 2024

Tests performed:
Used the following sql and checked if any of the Refugees are visible in Stormwind harbor while gm off

DELETE FROM `disables` WHERE `sourceType`=9 AND `entry`=11595;
INSERT INTO `disables` (`sourceType`, `entry`, `flags`, `params_0`, `params_1`, `comment`) VALUES 
(9, 11595, 0, '', '', 'Disable Darnassian and Gilnean Refugees phase');

Note:
Also thought about skipping loading of objects with disabled phases entirely, but since this table is reloadable and creature/gameobject isn't i decided to just not apply the phase to the players

@Shauren
Copy link
Member

Shauren commented May 27, 2024

  1. Why go this ways intead of just removing phase_area?
  2. Name is too generic for what it does, it disables phase_area, not the phase (still works if gained from aura)

@mdX7
Copy link
Member Author

mdX7 commented May 28, 2024

  1. Why go this ways intead of just removing phase_area?

so its easier to re-enable them without looking years of commit history back to find the related phase_area lines

@mdX7 mdX7 changed the title Core/Disables: Added DISABLE_TYPE_PHASE Core/Disables: Added DISABLE_TYPE_PHASE_AREA May 30, 2024
@mdX7 mdX7 merged commit 3aae692 into TrinityCore:master Jun 3, 2024
6 checks passed
@mdX7 mdX7 deleted the disables/phase branch June 3, 2024 22:44
Ovahlord pushed a commit that referenced this pull request Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants