Core/Spells: Fix dispelling movement impairing auras by PvP-trinket and similar spells. #29966
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed:
After 3306a4d spells that grant immunity to mechanics do not completely remove the auras that these mechanics have on only one of their effects. Instead, these effects are only temporarily disabled.
However, there seem to be exceptions to this. For example, PvP-trinkets, or Human racial "Every Man for Himself".
Such spells are distinguished by the duration of their aura - only 100 ms. Of course, they should completely remove the auras they grant immunity to, and not just disable some effects for 100 milliseconds.
How to reproduce:
.aura 31589
This PR fixed the issue.
Tests performed:
Builded and tested in-game.