add sharePath url option setting #1288
Draft
+221
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've put it into draft for you :-) will have a look at this later this evening (CET time :-)) - this time hopefully without too much confusion from my side ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to #1207 bare2share: adding a sharePath option setting under Other so that the anonymous url path can be
/or/fooinstead of hardcoded to/share.The options setting page is setup and works in that the setting is saved, but routing for anonymous user is broken. I'm stuck for now.
(meta: npx prettier has not been run. Also I don't see the control for setting this PR to draft, sorry. Review still welcome though!)