Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies and use the latest PyInstaller version #7958

Draft
wants to merge 4 commits into
base: release/7.14
Choose a base branch
from

Conversation

kozlovsky
Copy link
Collaborator

This PR attempts to fix MacOS segfaulting by upgrading Qt-related dependencies and updating PyInstaller to the latest version.

After the installation on MacOS, it is necessary to open the terminal and perform the following command:

xattr -c /Applications/Tribler.app

Or, alternatively:

xattr -d com.apple.quarantine /Applications/Tribler.app

Without it, MacOS falsely reports that the application is corrupted, but it just means that it is not signed.

@kozlovsky kozlovsky requested a review from xoriole April 8, 2024 08:08
@xoriole
Copy link
Contributor

xoriole commented Apr 8, 2024

As an important consideration, these dependencies should be tested to work on Ubuntu (18.04) with glibc 2.27 as well. That usually places some constraints on PyQt5 and Pillow.

@drew2a
Copy link
Collaborator

drew2a commented Apr 8, 2024

This fact can be a show-stopper for our users:

After the installation on MacOS, it is necessary to open the terminal and perform the following command:
xattr -c /Applications/Tribler.app

@kozlovsky
Copy link
Collaborator Author

This fact can be a show-stopper for our users

The only way to properly solve this is to obtain a Developer ID certificate to sign binaries. Until we have this certificate, asking users to execute a command in the terminal looks acceptable to me.

It is not strategically viable to use obsolete versions of PyInstaller and dependencies forever to get a slightly less ugly warning when Tribler first starts.

@drew2a
Copy link
Collaborator

drew2a commented Apr 8, 2024

We currently don't have any ugly warnings on macOS.

We utilize the well-known "right-click" -> "open" trick, which remains the same for all applications from an unidentified developer.

https://support.apple.com/guide/mac-help/open-a-mac-app-from-an-unidentified-developer-mh40616/mac

What you're suggesting introduces something "unknown" to Mac users. It's quite suspicious (speaking as a Mac user myself) and not convenient.

I'm not the Product Owner, so I can't stop you from making such a risky change, but @synctext should at least be informed about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants