Skip to content

Preset breakpoints in per project .bashdbrc #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 7, 2025

Conversation

schnell18
Copy link
Contributor

@schnell18 schnell18 commented Jun 4, 2025

This PR implements #67 and fixes a minor bug in the condition command. A new integration test case has been added to cover the new feature. Detailed changes are as follows

  • Preset breakpoints in per project .bashdbrc
  • Fix failure to set conditional breakpoint using condition command
  • Document startup behavior under "entry-exit" section

@schnell18 schnell18 changed the title Implement #67 Implement #67 to preset breakpoints in per project .bashdbrc Jun 4, 2025
@schnell18 schnell18 changed the title Implement #67 to preset breakpoints in per project .bashdbrc Preset breakpoints in per project .bashdbrc Jun 4, 2025
@rocky
Copy link
Collaborator

rocky commented Jun 4, 2025

Looks good to me. @jansorg Do you have any comments or concerns?

Copy link
Collaborator

@jansorg jansorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor notes.
Thank you for your contribution!

- Preset breakpoints in per project .bashdbrc
- Fix failure to set conditional breakpoint using condition command
- Document startup behavior under "entry-exit" section

Signed-off-by: Justin Zhang <[email protected]>
@rocky
Copy link
Collaborator

rocky commented Jun 7, 2025

@jansorg Are your comments/concerns all addressed now?

@jansorg
Copy link
Collaborator

jansorg commented Jun 7, 2025

Yes, I'm good now.

@rocky rocky merged commit 7d0f975 into Trepan-Debuggers:bash-5.2 Jun 7, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants