Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fixed test_numpy_mean for all backends #28755

Merged
merged 1 commit into from
May 23, 2024
Merged

fix: fixed test_numpy_mean for all backends #28755

merged 1 commit into from
May 23, 2024

Conversation

ZenithFlux
Copy link
Contributor

PR Description

  • fixed the tuple destructuring error in the function.
  • Numpy's mean is not as exact as of other frameworks. It sometimes rounds up the mean while other frameworks don't which causes some mismatch in results. Therefore an atol of 0.0005 is added to the test.

Related Issue

Closes #28751
Closes #28752
Closes #28753
Closes #28754

Checklist

  • Did you add a function?
  • Did you add the tests?
  • Did you run your tests and are your tests passing?
  • Did pre-commit not fail on any check?
  • Did you follow the steps we provided?

Socials

@Sam-Armstrong Sam-Armstrong self-assigned this May 23, 2024
@Sam-Armstrong Sam-Armstrong self-requested a review May 23, 2024 21:55
@Sam-Armstrong
Copy link
Contributor

Apologies for the delayed review @ZenithFlux, looks good to me. Thanks for the contribution!

@Sam-Armstrong Sam-Armstrong merged commit 7c2fa8a into Transpile-AI:main May 23, 2024
5 of 7 checks passed
@ZenithFlux ZenithFlux deleted the fixing_test_numpy_mean branch May 25, 2024 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sam-Armstrong Sam-Armstrong Awaiting requested review from Sam-Armstrong Sam-Armstrong is a code owner

Assignees

@Sam-Armstrong Sam-Armstrong

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@ZenithFlux @Sam-Armstrong