fix: Take into account frontend supported dtypes in frontend tests #23430
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
There is a problem with function
helpers.get_dtypes
.If
prune_function==True
backend and function are taken into account through_get_supported_devices_dtypes
.If prune_function==False,
_get_type_dict
is used asretrieval_fn
This
retrieval_fn
is used with parameteris_frontend_test=False
which leads to considering only ivy framework dtypes,if
is_frontend_test
wasTrue
, the passed framework would be considered frontend and only that would be taken into account.The
prune_function==True
branch seems to miss the frontend dtypes in case we are in a frontend test.The
prune_function==False
branch, the way it is currently used, seems to miss both frontend and backend dtypes, only ivy dtypes are considered.Trello