Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Take into account frontend supported dtypes in frontend tests #23430

Merged
merged 11 commits into from
Sep 19, 2023

Conversation

ReneFabricius
Copy link
Contributor

@ReneFabricius ReneFabricius commented Sep 11, 2023

PR Description

There is a problem with function helpers.get_dtypes.

If prune_function==True backend and function are taken into account through _get_supported_devices_dtypes.

If prune_function==False,
_get_type_dict is used as retrieval_fn
This retrieval_fn is used with parameter is_frontend_test=False which leads to considering only ivy framework dtypes,
if is_frontend_test was True, the passed framework would be considered frontend and only that would be taken into account.

The prune_function==True branch seems to miss the frontend dtypes in case we are in a frontend test.
The prune_function==False branch, the way it is currently used, seems to miss both frontend and backend dtypes, only ivy dtypes are considered.

Trello

@github-actions
Copy link
Contributor

Thanks for contributing to Ivy! 😊👏
Here are some of the important points from our Contributing Guidelines 📝:
1. Feel free to ignore the run_tests (1), run_tests (2), … jobs, and only look at the display_test_results job. 👀 It contains the following two sections:
- Combined Test Results: This shows the results of all the ivy tests that ran on the PR. ✔️
- New Failures Introduced: This lists the tests that are passing on main, but fail on the PR Fork. Please try to make sure that there are no such tests. 💪
2. The lint / Check formatting / check-formatting tests check for the formatting of your code. 📜 If it fails, please check the exact error message in the logs and fix the same. ⚠️🔧
3. Finally, the test-docstrings / run-docstring-tests check for the changes made in docstrings of the functions. This may be skipped, as well. 📚
Happy coding! 🎉👨‍💻

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Issue Reference

In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our contributing guide and our PR template.
This check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.

@ReneFabricius ReneFabricius changed the title Set ground truth backend for frontend tests Take into account frontend supported dtypes in frontend tests Sep 14, 2023
@ReneFabricius ReneFabricius changed the title Take into account frontend supported dtypes in frontend tests fix: Take into account frontend supported dtypes in frontend tests Sep 18, 2023
@ReneFabricius ReneFabricius merged commit ac438e3 into Transpile-AI:main Sep 19, 2023
134 of 139 checks passed
@ReneFabricius ReneFabricius deleted the ground_truth_frontends branch September 21, 2023 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants