[Breaking] Change bytestream to array-based config #1806
Conversation
There was a problem hiding this comment.
Reviewable status: 0 of 1 LGTMs obtained, and 0 of 16 files reviewed, and pending CI: Analyze (javascript-typescript), Analyze (python), Bazel Dev / macos-15, Bazel Dev / ubuntu-24.04, Cargo Dev / macos-15, Cargo Dev / ubuntu-24.04, Coverage, Installation / macos-14, Installation / macos-15, Installation / ubuntu-22.04, Installation / ubuntu-24.04, Local / bazel / ubuntu-24.04, Local / lre-cc / ubuntu-24.04, Local / lre-rs / macos-15, Local / lre-rs / ubuntu-24.04, NativeLink.com Cloud / Remote Cache / macos-15, NativeLink.com Cloud / Remote Cache / ubuntu-24.04, Publish image, Publish nativelink-worker-init, Publish nativelink-worker-lre-cc, Remote / lre-cc / xlarge-ubuntu-24.04, Remote / lre-rs / xlarge-ubuntu-24.04, Web Platform Deployment / macos-15, Web Platform Deployment / ubuntu-24.04, asan / ubuntu-24.04, buildstream, integration-tests (24.04), macos-15, pre-commit-checks, ubuntu-24.04, ubuntu-24.04 / stable, vale, windows-2022 / stable (waiting on @aaronmondal)
In contrast to TraceMachina#1712, there's no backwards-compatibility layer. Closes TraceMachina#1649
jaroeichler
force-pushed
the
bytestream-config
branch
from
8643700 to
67500dd
Compare
|
This is not finished. It needs more work. |
There was a problem hiding this comment.
LGTM
@palfrey could you take a look as well. The bytestream bit was the final one that we needed to improve. This goes back to an issue from nearly two years ago, but it was like pulling teeth to get one of the approvers onboard. This is a great improvement.
|
cannot merge until conflicts resolved |
In contrast to #1712, there's no backwards-compatibility layer.
Closes #1649
This change is