Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor using a base widget class #35

Merged
merged 13 commits into from
Mar 14, 2024
Merged

Refactor using a base widget class #35

merged 13 commits into from
Mar 14, 2024

Conversation

caguero
Copy link
Collaborator

@caguero caguero commented Feb 27, 2024 •
edited
Loading

For now, it's working for the rotational and dial gauges. Dial needs a bit more work.

All gauges should be functional.

@caguero
Creating a base_widget class.
05dc0b7 
Signed-off-by: Carlos Agüero <[email protected]>
@caguero
Tweak.
dbd076b 
Signed-off-by: Carlos Agüero <[email protected]>
@caguero
Style
347172f 
Signed-off-by: Carlos Agüero <[email protected]>
@ahcorde
Copy link
Collaborator

ahcorde commented Feb 28, 2024

@caguero is this ready for review?

@ahcorde ahcorde self-requested a review February 28, 2024 12:54
@caguero
Copy link
Collaborator Author

caguero commented Feb 28, 2024

@caguero is this ready for review?

Not yet.

@caguero
More updates.
7d78d2e 
Signed-off-by: Carlos Agüero <[email protected]>
@caguero
Adding files.
47d47ba 
Signed-off-by: Carlos Agüero <[email protected]>
@caguero
Adding files.
10b570f 
Signed-off-by: Carlos Agüero <[email protected]>
@caguero
Tweaks
e18e086 
Signed-off-by: Carlos Agüero <[email protected]>
@caguero
Updates
932d144 
Signed-off-by: Carlos Agüero <[email protected]>
@caguero
Functional
26b3b1a 
Signed-off-by: Carlos Agüero <[email protected]>
@caguero
QT Style
10bad3b 
Signed-off-by: Carlos Agüero <[email protected]>
@caguero
Clean
011fc31 
Signed-off-by: Carlos Agüero <[email protected]>
@caguero caguero marked this pull request as ready for review March 5, 2024 20:17
@caguero
Copy link
Collaborator Author

caguero commented Mar 5, 2024

@caguero is this ready for review?

Not yet.

Good to go!

ahcorde
ahcorde requested changes Mar 7, 2024
View reviewed changes
Copy link
Collaborator

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • In the dial the units are not working
  • the minimum value in the rotational widge should be -45 and not 0

@caguero
Tweaks
d5ebb40 
Signed-off-by: Carlos Agüero <[email protected]>
@caguero
Copy link
Collaborator Author

caguero commented Mar 7, 2024

  • In the dial the units are not working
  • the minimum value in the rotational widge should be -45 and not 0

It should be fixed in d5ebb40

@caguero caguero requested a review from ahcorde March 7, 2024 15:35
@ahcorde
Copy link
Collaborator

ahcorde commented Mar 12, 2024

gauges_not_wroking

  • min value in rotational is not working
  • min and max values not working on bar gauges

ahcorde
ahcorde requested changes Mar 12, 2024
View reviewed changes
Copy link
Collaborator

@ahcorde ahcorde left a comment •
edited by caguero
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment

@caguero
Tweak limits.
fcd44f5 
Signed-off-by: Carlos Agüero <[email protected]>
@caguero
Copy link
Collaborator Author

caguero commented Mar 13, 2024

fcd44f5

I tweaked the limits in some widgets. Could you check now?

@caguero caguero requested a review from ahcorde March 13, 2024 15:32
@ahcorde ahcorde merged commit cec91ed into main Mar 14, 2024
2 checks passed
@ahcorde ahcorde deleted the caguero/base_widget branch March 14, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahcorde ahcorde ahcorde approved these changes

Assignees

@caguero caguero

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@caguero @ahcorde