Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Nu-7702] Warn user when scenario version is outdated before save or deploy #7732

Merged

Conversation

DeamonDev
Copy link
Contributor

@DeamonDev DeamonDev commented Mar 23, 2025

Describe your changes

I implemented mechanism to warn user when tries to save version of scenario which is not the recent one (for example because someone else modified it in the meantime).

image

The analogous warning is added for deployment button

image

Checklist before merge

  • Related issue ID is placed at the beginning of PR title in [brackets] (can be GH issue or Nu Jira issue)
  • Code is cleaned from temporary changes and commented out lines
  • Parts of the code that are not easy to understand are documented in the code
  • Changes are covered by automated tests
  • Showcase in dev-application.conf added to demonstrate the feature
  • Documentation added or updated
  • Added entry in Changelog.md describing the change from the perspective of a public distribution user
  • Added MigrationGuide.md entry in the appropriate subcategory if introducing a breaking change
  • Verify that PR will be squashed during merge

@DeamonDev DeamonDev self-assigned this Mar 23, 2025
@github-actions github-actions bot added client client main fe ui labels Mar 23, 2025
@DeamonDev DeamonDev linked an issue Mar 23, 2025 that may be closed by this pull request
@DeamonDev DeamonDev force-pushed the nu-7702-warn-user-when-scenario-version-is-outdated branch from 0a724b2 to cc1caf2 Compare March 24, 2025 14:30
Copy link
Contributor

github-actions bot commented Mar 24, 2025

created: #7774
⚠️ Be careful! Snapshot changes are not necessarily the cause of the error. Check the logs.

@DeamonDev DeamonDev force-pushed the nu-7702-warn-user-when-scenario-version-is-outdated branch 4 times, most recently from 0337d14 to 5d0deb0 Compare March 25, 2025 12:09
@DeamonDev DeamonDev marked this pull request as ready for review March 25, 2025 12:13
@DeamonDev DeamonDev force-pushed the nu-7702-warn-user-when-scenario-version-is-outdated branch 8 times, most recently from 7999103 to 6d12c59 Compare March 26, 2025 15:08
@DeamonDev DeamonDev force-pushed the nu-7702-warn-user-when-scenario-version-is-outdated branch from 6d12c59 to 3bbd821 Compare March 27, 2025 08:43
@DeamonDev DeamonDev requested a review from Dzuming March 27, 2025 09:15
Copy link
Contributor

@Dzuming Dzuming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DeamonDev DeamonDev merged commit 3e71efd into staging Mar 27, 2025
19 checks passed
@DeamonDev DeamonDev deleted the nu-7702-warn-user-when-scenario-version-is-outdated branch March 27, 2025 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client main fe ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warn user when scenario version is outdated before save or deploy
2 participants