Skip to content

Conversation

@ForrestFairy
Copy link
Contributor

@ForrestFairy ForrestFairy commented Feb 11, 2025

Describe your changes

key variable was created in window components by taking values from groupBy and parsing them to a list in string. Now it will be passed as a value which was provided, eg.

for id = 1
Before -> groupBy: id -> key: "[1]"
After -> groupBy: id -> key: 1

For old scenarios users would need to go into aggregation components and edit groupBy field for it to take effect. Otherwise it will still create key variable as string

Checklist before merge

  • Related issue ID is placed at the beginning of PR title in [brackets] (can be GH issue or Nu Jira issue)
  • Code is cleaned from temporary changes and commented out lines
  • Parts of the code that are not easy to understand are documented in the code
  • Changes are covered by automated tests
  • Showcase in dev-application.conf added to demonstrate the feature
  • Documentation added or updated
  • Added entry in Changelog.md describing the change from the perspective of a public distribution user
  • Added MigrationGuide.md entry in the appropriate subcategory if introducing a breaking change
  • Verify that PR will be squashed during merge

@github-actions github-actions bot added client client main fe ui labels Feb 11, 2025
@ForrestFairy ForrestFairy force-pushed the key-var-change branch 3 times, most recently from 6ef97d7 to 230bc1b Compare February 12, 2025 14:22
@github-actions github-actions bot added the docs label Feb 13, 2025
@ForrestFairy ForrestFairy marked this pull request as ready for review February 14, 2025 08:52
@github-actions
Copy link
Contributor

github-actions bot commented Mar 18, 2025

created: #7860
⚠️ Be careful! Snapshot changes are not necessarily the cause of the error. Check the logs.

@raphaelsolarski raphaelsolarski deleted the key-var-change branch April 2, 2025 05:15
@raphaelsolarski raphaelsolarski restored the key-var-change branch April 2, 2025 05:19
Copy link
Contributor

@arkadius arkadius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I read only last 3 commits, they look ok for me

@raphaelsolarski raphaelsolarski merged commit fecfd1e into staging Apr 17, 2025
17 of 18 checks passed
@raphaelsolarski raphaelsolarski deleted the key-var-change branch April 17, 2025 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client client main fe docs ui

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants