-
Notifications
You must be signed in to change notification settings - Fork 103
[NU-1977] Key variable change in window components
#7553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6ef97d7 to
230bc1b
Compare
e6a94db to
cf099e5
Compare
raphaelsolarski
suggested changes
Feb 21, 2025
designer/client/src/components/graph/node-modal/aggregate/useAggParamsSerializer.tsx
Outdated
Show resolved
Hide resolved
engine/flink/components-utils/src/main/scala/pl/touk/nussknacker/engine/flink/util/keyed.scala
Outdated
Show resolved
Hide resolved
3f4bfbf to
ff38bed
Compare
4376f51 to
f9f3189
Compare
Contributor
|
created: #7860 |
f9f3189 to
a28f35d
Compare
raphaelsolarski
suggested changes
Mar 25, 2025
designer/client/src/components/graph/node-modal/aggregate/useAggParamsSerializer.tsx
Outdated
Show resolved
Hide resolved
designer/client/src/components/graph/node-modal/aggregate/useAggParamsSerializer.tsx
Outdated
Show resolved
Hide resolved
a28f35d to
594aec5
Compare
594aec5 to
c1c5134
Compare
raphaelsolarski
approved these changes
Apr 2, 2025
arkadius
approved these changes
Apr 2, 2025
Contributor
arkadius
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I read only last 3 commits, they look ok for me
…more complex cases
9912047 to
e33b5fe
Compare
JulianWielga
approved these changes
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
keyvariable was created in window components by taking values fromgroupByand parsing them to a list in string. Now it will be passed as a value which was provided, eg.For old scenarios users would need to go into aggregation components and edit
groupByfield for it to take effect. Otherwise it will still createkeyvariable as stringChecklist before merge