kafka: switching from zk to kraft in tests #5461
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
created: #6669 |
piotrp
force-pushed
the
kafka-kraft-in-tests
branch
from
ae97396
to
b5828fc
Compare
9 tasks
arkadius
force-pushed
the
kafka-kraft-in-tests
branch
from
2c9cf4e
to
2160905
Compare
coutoPL
reviewed
Aug 29, 2024
| @@ -47,6 +47,8 @@ class StreamingEmbeddedDeploymentManagerRestartTest extends BaseStreamingEmbedde | |||
| jobStatuses.map(_.status) shouldBe List(SimpleStateStatus.Restarting) | |||
| } | |||
|
|
|||
| // We have to recreate kafka server because after shutdown it is unusable anymore | |||
| kafkaServer.recreateKafkaServer() | |||
| kafkaServer.kafkaServer.startup() | |||
There was a problem hiding this comment.
kafkaServer.kafkaServer looks weird. Can we rename the field to underlying or sth like that?
| val kafkaAddress: String, | ||
| tempDir: File | ||
| ) extends LazyLogging { | ||
|
|
||
| var kafkaServer: Server = createKafkaServer() |
There was a problem hiding this comment.
why do we have to expose the underlying server? let's keep it as internal
| var kafkaServer: Server = createKafkaServer() | ||
|
|
||
| def recreateKafkaServer(): Unit = { | ||
| kafkaServer = createKafkaServer() |
There was a problem hiding this comment.
what about closing the previously created server?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Checklist before merge