-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: duplicate danmaku filename when fallback #190
Conversation
删除文件那里是不是也要改下 |
这个倒是不需要,删除文件那里是遍历所有弹幕源对应的弹幕文件进行删除的,不会有遗漏的 Lines 382 to 386 in 7ed245a
|
OK,那原来的 rm 逻辑是不是可以清理下,比如 rm3 应该不需要了 |
可以,那就去掉吧
不对,我犯傻了,rm5 |
突然发现巴哈姆特弹幕文件保存用的文件名是 我把这个也顺便一起改了 |
ok,改完了 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
由于不只是电影电视剧,正常的从源添加弹幕有时也会回落到
get_danmaku_fallback
函数。而由于get_danmaku_fallback
设置的弹幕文件名的重复,会导致新fallback到get_danmaku_fallback
函数获取的弹幕,会覆盖之前别的fallback的弹幕源的弹幕。因此添加了count作为唯一标识,避免弹幕文件名重复。