fix: repeat initialization #187
Merged
+11
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
和我一开始以为的不同，设置按钮并不会导致重复调用。真正的重复调用发生在 addon_danmaku() 中，但好像不太好处理， @Tony15246 有什么想法吗？有必要对此进行处理吗 |
我没看出来addon_danmaku()是如何导致init()被重复调用的🥲 |
我表达的不够清楚，我是在测试电影电视弹幕加载时发现有时会重复输出弹幕加载消息，查看了下代码以为是设置按钮时重复调用 init() 导致的。但经过测试排查发现其实不是，是 addon_danmaku() 重复解析了一遍弹幕 url 已修复 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
按钮设置在 init() 调用的各个函数中会自动执行，无需提前设置，反而导致重复调用 init()