-
-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes the missing null values in the output #317
Conversation
The change looks good - could I ask you to add a test for this please? Just the example you gave in the original issue would be good enough. You can add a top level test here: dasel/internal/command/select_test.go Line 41 in 3b466e8
|
9a9468b
to
e5bc0e0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll look at the failing test tomorrow
Tests started failing after Ordered maps #289 merge. |
I slightly debugged to find out which changes cause to fail. Seems like It is the same reason as #296. |
OK thanks - I'll take a look to see what I broke with that PR and merge this when resolved 👍 |
Hey @semihbkgr, sorry for the delay. I've fixed the issue - the root cause was a new data structure being used to allow for ordered maps. I just had to replicate the same logic in another place. Thanks for the contribution! |
fixes #316