Skip to content

Feat: add formatter options to render command #4753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

georgesittas
Copy link
Contributor

No description provided.

@georgesittas georgesittas requested a review from a team June 17, 2025 12:14
@georgesittas georgesittas force-pushed the jo/add_format_opts_to_render branch 2 times, most recently from 219adf4 to 6fdbee1 Compare June 17, 2025 12:30
@georgesittas georgesittas force-pushed the jo/add_format_opts_to_render branch from 6fdbee1 to 36e09e5 Compare June 17, 2025 13:07
@benfdking
Copy link
Contributor

My wonder here is whether we should try to standardise it into a struct that is much easier to reuse that the flags pass in. For me if you want to format it in a certain way, you probably want it in your config.

@georgesittas
Copy link
Contributor Author

georgesittas commented Jun 17, 2025

My wonder here is whether we should try to standardise it into a struct that is much easier to reuse that the flags pass in. For me if you want to format it in a certain way, you probably want it in your config.

@benfdking we have a pydantic model for that config already. I've used it in this PR as well. It's just that we allow you to override the various settings in one-off render commands.

@georgesittas georgesittas force-pushed the jo/add_format_opts_to_render branch from bb2c0ff to a8f2293 Compare June 19, 2025 16:31
@georgesittas georgesittas force-pushed the jo/add_format_opts_to_render branch from a8f2293 to 7bac9e1 Compare June 19, 2025 16:42
@georgesittas georgesittas requested a review from a team June 19, 2025 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants