fix: correct typehints in project #395
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tishka17
reviewed
May 2, 2024
| def __eq__(self, other): | ||
| if type(other) is not MediaId: | ||
| def __eq__(self, other: object) -> bool: | ||
| if not isinstance(other, MediaId): |
Tishka17
reviewed
May 2, 2024
| @@ -7,6 +7,7 @@ | |||
| from aiogram.fsm.state import State | |||
|
|
|||
| from aiogram_dialog.api.exceptions import DialogStackOverflow | |||
|
|
|||
There was a problem hiding this comment.
we had a discussion that this is probably can be configured
Tishka17
reviewed
May 2, 2024
| from aiogram_dialog.api.protocols import DialogProtocol | ||
|
|
||
|
|
||
| @runtime_checkable | ||
| class Widget(Protocol): | ||
| @abstractmethod | ||
| def managed(self, manager: DialogManager) -> Any: | ||
| def managed(self, manager: DialogManager) -> "Widget": |
There was a problem hiding this comment.
it does'n return widget, it returns managed version of widget - it's a differnt type.
Tishka17
reviewed
May 2, 2024
| @@ -28,7 +34,9 @@ def find(self, widget_id: str) -> Optional["Widget"]: | |||
| class TextWidget(Widget, Protocol): | |||
| @abstractmethod | |||
| async def render_text( | |||
| self, data: Dict, manager: DialogManager, | |||
| self, | |||
| data: Dict[str, Union[DataDict, Dict[str, Any], ChatEvent]], | |||
There was a problem hiding this comment.
Very strange values. I believe it should be data: Dict[str, Any]
Tishka17
reviewed
May 2, 2024
| from aiogram_dialog.api.entities import Data, LaunchMode, NewMessage | ||
| from ..internal import Widget | ||
|
|
||
| from ... import ChatEvent |
There was a problem hiding this comment.
- Please, avoid
...imports. I would allow relative import within widgets package, but not outside of it. - Do not import from library package itself, import from subpackages, otherwise it will lead to cycle imports
Tishka17
reviewed
May 2, 2024
| ) -> None: | ||
| raise NotImplementedError | ||
|
|
||
| @abstractmethod | ||
| def find(self, widget_id) -> Any: | ||
| def find(self, widget_id: str) -> Optional[Widget]: |
There was a problem hiding this comment.
again, it is not widget returned, but "managed" one
Tishka17
reviewed
May 2, 2024
| type: ContentType, | ||
| media_id: MediaId, | ||
| self, | ||
| path: Optional[Union[str, Path]], |
There was a problem hiding this comment.
It breaks compatibility, let's keep str
Tishka17
reviewed
May 2, 2024
| intent_id, | ||
| stack_id, | ||
| event.from_user.id, | ||
| cast(User, event.from_user).id, |
There was a problem hiding this comment.
looks like we need to add check instead of cast
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.