Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix service UUID filter and fix advertisement data get wiped when the advertisement is split #29

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

rickymohk
Copy link

@rickymohk rickymohk commented Jul 14, 2022

Fix service UUID filter issue (#18). by creating one watcher for each service UUID.
For the advertisement, since Windows may receive the advertisement in two parts when doing active scan (e.g. first part contains service UUIDs, second part contains manufacturer data), if the fields that don't exist are set to empty strings or empty arrays, the previously received data will get wiped. Non-existing field should not be set and Noble will merge the split parts together.

@rickymohk rickymohk changed the title Fix service UUID filter and fix advertisement data get wiped when the advertisement is splitted Fix service UUID filter and fix advertisement data get wiped when the advertisement is split Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant