Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary uses of TILEDB_EXPORT. #364

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

teo-tsirpanis
Copy link
Member

SC-61398

The TILEDB_EXPORT symbol is defined in tiledb.h to mark exported functions of the TileDB C API, and should not be used by external code. Removing its use in TileDB-Go fixes compile errors on Windows.

@teo-tsirpanis teo-tsirpanis requested a review from a team as a code owner January 7, 2025 11:43
@teo-tsirpanis teo-tsirpanis mentioned this pull request Jan 7, 2025
@teo-tsirpanis teo-tsirpanis merged commit 0ed55b8 into TileDB-Inc:master Jan 7, 2025
6 checks passed
@teo-tsirpanis teo-tsirpanis deleted the tiledb-export branch January 7, 2025 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants