-
Notifications
You must be signed in to change notification settings - Fork 3
Summarize XPASS-ing tests in CI #714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8bf5114
to
87f708e
Compare
sgillies
commented
Mar 6, 2025
path: .test_durations | ||
key: ${{ env.PYTEST_TEST_DURATIONS_CACHE_KEY }}-${{ hashFiles('.test_durations') }} | ||
echo "XPASSes:" >> $GITHUB_STEP_SUMMARY | ||
grep --recursive --with-filename "XPASS" test-outputs >> $GITHUB_STEP_SUMMARY |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been unable to get "^XPASS"
to work as a pattern, neither with nor without --extended-regexp
. In the GHA runner, it matches nothing.
ktsitsi
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're xfailing some tests that have a history of flakiness or timing out, but it's difficult to see when they xpass in the GitHub UI. You have to click through each job, find the step and scroll through it. And we've got a lot of jobs.
I've tried to add a summary job. It's not very fancy (I'm having trouble reproducing some unexpected grep behavior on my laptop), but it does show every xfailing test with information that helps guide us back to the particular job.
For example, this
tells us that two tests unexpectedly passed. Both with Python 3.9 (the Python 3.12 tests don't exercise UDFs or task graphs), pinned dependencies. One test is part 2 of the batch of splits, one in part 4.
In the UI, it looks like this:
The history of this PR is a mess. The net changes are small.