Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addresses #7836: Noisy $fill widgets #8930

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

flibbles
Copy link
Contributor

@flibbles flibbles commented Feb 4, 2025

$fill widgets will get ignored when encountered by ts-raw slots

There. If anyone complains about the loss of the old behavior, I will eat my T-shirt and post it to YouTube.

$fill widgets will get ignored when encountered by ts-raw slots
Copy link

github-actions bot commented Feb 4, 2025

Confirmed: flibbles has already signed the Contributor License Agreement (see contributing.md)

Copy link

netlify bot commented Feb 4, 2025

Deploy Preview for tiddlywiki-previews ready!

Name Link
🔨 Latest commit 3425dd1
🔍 Latest deploy log https://app.netlify.com/sites/tiddlywiki-previews/deploys/67a193354a50320008c26a6a
😎 Deploy Preview https://deploy-preview-8930--tiddlywiki-previews.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rmunn
Copy link
Contributor

rmunn commented Feb 4, 2025

Thank you; this is exactly how I wanted <$fill> widgets to work.

Here's a quick test case I did:

\widget $my.widget(label:"")
<$slot $name="header"/>
<fieldset>
   <legend>&nbsp;<$text text=<<label>>/>&nbsp;</legend>
   <$slot $name="ts-raw"/>
</fieldset>
\end $my.widget

<$my.widget label="important">
<$fill $name=header>My widget header</$fill>

content of widget
</$my.widget>

What that looks like in TW prerelease right now:

image

What it looks like with this PR applied:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants