Return the auth challenge in the WWW-Authenticate when auth fails #1387
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes / New Feature
Perform Challenge on failed authentication, and return the generated WWW-Authenticate header in the upstream response.
Proposed Changes
AuthenticationMiddleware.cs
: perform a challenge whenever authentication fails. This generates aWWW-Authenticate
header on the response.httpContext.Response
that is available inAuthenticationMiddleware.cs
is recreated/overwritten further down the pipeline, so we need to preserve the generatedWWW-Authenticate
header somewhere. For now, I've put it in thehttpContext.Items
(suggestions on how to do this in a better way are highly appreciated).WWW-Authenticate
header on the response inResponderMiddleware.cs
.