MySQL Binlog #11
MySQL Binlog #11
Conversation
| return errors.New("offsets adapter is nil") | ||
| } | ||
| if c.Database.Flavour != mysql.MySQLFlavor && c.Database.Flavour != mysql.MariaDBFlavor { | ||
| return errors.New("database config incorrect flavour value") |
There was a problem hiding this comment.
The error message could list the allowed flavours.
Otherwise, the consumer of the error will have to arrive to this line in the source code to find out what values are allowed.
|
Hello @0michalsokolowski0! Thank you for this! I'm tasked with porting parts of a legacy message driven application to go, in which mutating the status column (by the legacy parts) are significant events. Is this branch currently usable for early incorporation? Do you expect the it's public API is still going to change? |
Hi @blaggacao , it is still work in progress and as I wrote above it needs to be tested more thoroughly. |
Data mapping
In the current implementation of subscriber,
it is assumed that funtion
UnmarshalMessage(SchemaAdapter) is used to extract data from a row. However, in the case of binlog I found this functionunusable because of the parameter
*sql.Row. As a result I am inferring the content of columns based on separate configurationColumnsMapping. Such an approach isinspired by go-mysql-elasticsearch.
Could you express your opinion on that? Can you suggest a better solution?
Database Access
In the current implementation of subscriber,
database related interface is an argument passed to the constructor.
As for as I can see, it does not make much sense in the case of a binlog subscriber.
In order to initialize the subscriber, a canal to database's binlog files needs to be created.
The initialization require credentials and details of the database (expressed in
Databasestruct)this information is accessible only when explicitly passed to the subscriber which makes
beginner redundant.
Right now for simplicity I am using a hybrid solution, but it clearly needs correction.
I would like to remove usage of the interface from the constructor and initialize the connection to the database myself.
Could you express your opinion on that? Can you suggest a better solution?
TODO
mapRow,getBytesandgetNumber.ColumnsMappingRow structDatabasestruct)