Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(This is on top of my previous pr that fixes the rgba txt2mask error, otherwise I can't run anything)
I tried for a bit to fix the padding in txt2mask, but conceptually I don't think that the way that it was working (a resize and a crop) is actually how you need it to work to properly pad the mask. Since we have opencv anyway, this pr changes it to a dilate on the mask, which is closer to padding pixels around the alpha areas.
It isn't perfect, since a dilate loses a lot of the definition of the mask. Probably what we actually want is to threshold a distance map which I believe will give us a better result, but it's at the very least more than I want to get into tonight.