Skip to content

Conversation

@tdilauro
Copy link
Contributor

Description

Log messages for successful extraction of a patron ID from a SAML Subject will now include the name of the attribute from which the patron ID was extracted. It will instead include the string "NameID" if we did not have an attribute match, but were able to fall back to the nameID.

Motivation and Context

It is helpful to know which attribute provided the patron ID, especially for configurations in which different attributes might sometimes provide the same value.

How Has This Been Tested?

  • Updated test cases to include the matching attribute, where appropriate.
  • All tests pass locally.
  • CI tests pass.

Checklist

  • I have updated the documentation accordingly.
  • All new and existing tests passed.

@tdilauro tdilauro requested a review from a team December 26, 2025 23:43
@codecov
Copy link

codecov bot commented Dec 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.78%. Comparing base (271f427) to head (2b11c64).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2950   +/-   ##
=======================================
  Coverage   92.78%   92.78%           
=======================================
  Files         454      454           
  Lines       42840    42844    +4     
  Branches     5975     5976    +1     
=======================================
+ Hits        39748    39752    +4     
  Misses       2021     2021           
  Partials     1071     1071           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants