Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add feature to display the number of projects in each section #4345

Merged
merged 6 commits into from
Jan 25, 2024
Merged

Add feature to display the number of projects in each section #4345

merged 6 commits into from
Jan 25, 2024

Conversation

sparshalc
Copy link
Contributor

Implementing a new feature to enhance the user experience by displaying the count of projects in each section. This feature addresses issue #4331.

image

KevinMulhern
KevinMulhern requested changes Jan 18, 2024
View reviewed changes
@KevinMulhern KevinMulhern temporarily deployed to odin-review-app-pr-4345 January 23, 2024 18:32 Inactive
KevinMulhern
KevinMulhern requested changes Jan 23, 2024
View reviewed changes
@KevinMulhern KevinMulhern temporarily deployed to odin-review-app-pr-4345 January 24, 2024 05:21 Inactive
KevinMulhern
KevinMulhern requested changes Jan 24, 2024
View reviewed changes
Copy link
Member

@KevinMulhern KevinMulhern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making those changes, just one more small change and I think we're good to ship. We'll need the merge conflict fixed too.

@KevinMulhern KevinMulhern added the create-review-app Create a Heroku review app for pull request label Jan 25, 2024
@KevinMulhern KevinMulhern temporarily deployed to odin-review-app-pr-4345 January 25, 2024 18:10 Inactive
@KevinMulhern KevinMulhern added destroy-review-app Destroy Heroku review app for pull request and removed create-review-app Create a Heroku review app for pull request labels Jan 25, 2024
@KevinMulhern KevinMulhern temporarily deployed to odin-review-app-pr-4345 January 25, 2024 22:01 Inactive
KevinMulhern
KevinMulhern approved these changes Jan 25, 2024
View reviewed changes
Copy link
Member

@KevinMulhern KevinMulhern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great, thanks @sparshalc

@KevinMulhern KevinMulhern merged commit 5df377f into TheOdinProject:main Jan 25, 2024
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KevinMulhern KevinMulhern KevinMulhern approved these changes

Assignees
No one assigned
Labels
destroy-review-app Destroy Heroku review app for pull request
Projects
Main Site
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sparshalc @KevinMulhern