Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(permutations): create exercise #444

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

feat(permutations): create exercise #444

wants to merge 16 commits into from

Conversation

NikitaRevenco
Copy link
Contributor

@NikitaRevenco NikitaRevenco commented Mar 23, 2024 •
edited
Loading

Because

It was decided to add new recursion exercises

This PR

  • Adds exercise 16

Previous

Issue

Related to #27265

Additional Information

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project Contributing Guide
  • The title of this PR follows the location of change: brief description of change format, e.g. 01_helloWorld: Update test cases
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If this PR includes any changes that affect the solution of an exercise, I've also updated the solution in the /solutions folder

@NikitaRevenco NikitaRevenco marked this pull request as draft March 23, 2024 15:01
@NikitaRevenco NikitaRevenco changed the title New exercise | sumSquares (16) New exercise | sumSquares Mar 23, 2024
@NikitaRevenco NikitaRevenco changed the title (16) New exercise | sumSquares (16) New exercise | Permutations Mar 24, 2024
@NikitaRevenco NikitaRevenco mentioned this pull request Mar 24, 2024
Open
3 tasks
@NikitaRevenco NikitaRevenco marked this pull request as ready for review April 4, 2024 17:10
@CouchofTomato CouchofTomato requested review from a team and bycdiaz and removed request for a team April 5, 2024 14:26
@NikitaRevenco NikitaRevenco mentioned this pull request Apr 6, 2024
Closed
6 tasks
MaoShizhong
MaoShizhong suggested changes Apr 7, 2024
View reviewed changes
Copy link
Contributor

@MaoShizhong MaoShizhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't looked at the the solution yet but one (technically 2) important change needed for the test suite below.

16_permutations/solution/permutations-solution.spec.js Outdated Show resolved Hide resolved
@NikitaRevenco NikitaRevenco changed the title (16) New exercise | Permutations feat(permutations): create exercise Aug 9, 2024
@MaoShizhong
Copy link
Contributor

Any issues with the comments above?

@NikitaRevenco
Copy link
Contributor Author

Any issues with the comments above?

Okay I have added your suggestions

@MaoShizhong MaoShizhong added the Status: Do Not Merge This PR should not be merged until further notice label Aug 20, 2024
@MaoShizhong MaoShizhong requested a review from JoshDevHub August 25, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaoShizhong MaoShizhong MaoShizhong requested changes

@bycdiaz bycdiaz Awaiting requested review from bycdiaz bycdiaz was automatically assigned from TheOdinProject/javascript

@JoshDevHub JoshDevHub Awaiting requested review from JoshDevHub

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Status: Do Not Merge This PR should not be merged until further notice
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NikitaRevenco @MaoShizhong