Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add easyinstall script #154

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Conversation

ChainDev162
Copy link

just for the sake of people not knowing how to use it, makes stuff a lot easier, and pretty straightforward for most people, seeing as the script already asks for login info upon launch.

@gianlucalauro
Copy link

The bash script works only if you're in a debian based distro.
It would be nice if there's an OS detection and use the appropriate package manager.
Also, the ability to choose if use docker or not.

@gianlucalauro
Copy link

Another implementation would be the possibility to add accounts during the prompt

@ChainDev162
Copy link
Author

ChainDev162 commented Oct 4, 2024

The bash script works only if you're in a debian based distro. It would be nice if there's an OS detection and use the appropriate package manager. Also, the ability to choose if use docker or not.

sure, i'll add that feature right away, and dosen't the script open a chromium instance that prompts you to login? i can spawn a window saying to put the acc creds in the accounts.json file?

@gianlucalauro
Copy link

It would be pretty, but I would say to parameterize it, because if you're using only a CLI OS you don't have a GUI to prompt the user and password

@ChainDev162
Copy link
Author

It would be pretty, but I would say to parameterize it, because if you're using only a CLI OS you don't have a GUI to prompt the user and password

ah, makes sense, gonna add that mater, school :P

@TheNetsky
Copy link
Owner

I guess once you've done that lmk

@ChainDev162
Copy link
Author

I guess once you've done that lmk

I did it, although I didn't have time to implement the account and login-related stuff. No CLI parameterization either, I'll implement those in the future though, once I have time.

@ChainDev162
Copy link
Author

Anyway, merge the files and contact me on Discord, @kduq.

@basalisco
Copy link

just for the sake of people not knowing how to use it, makes stuff a lot easier, and pretty straightforward for most people, seeing as the script already asks for login info upon launch.

I preferred a very sketchy bash script inserted in cron, which updates everything if needed rather than a script to install. Installation are just, some simple elementary commands.

1 similar comment
@basalisco
Copy link

just for the sake of people not knowing how to use it, makes stuff a lot easier, and pretty straightforward for most people, seeing as the script already asks for login info upon launch.

I preferred a very sketchy bash script inserted in cron, which updates everything if needed rather than a script to install. Installation are just, some simple elementary commands.

@ChainDev162
Copy link
Author

just for the sake of people not knowing how to use it, makes stuff a lot easier, and pretty straightforward for most people, seeing as the script already asks for login info upon launch.

I preferred a very sketchy bash script inserted in cron, which updates everything if needed rather than a script to install. Installation are just, some simple elementary commands.

yeah i know, but having a script that does all the work for you is just, convenient

@TheNetsky
Copy link
Owner

Any updated regarding this?

@ChainDev162
Copy link
Author

ChainDev162 commented Jan 27, 2025

Any updates regarding this?

Yep! I updated both the scripts (and removed some additional comments, used AI to implement the Docker prompt), you should be able to just install the corresponding install script without having to clone the whole repo and run the bot! Test what I committed and LMK if there are any errors that occur before accepting the PR.

@ChainDev162
Copy link
Author

I don't check my GitHub inbox often, so I apologize for my very late response.

@basalisco
Copy link

this is my little contribution with this little script by putting it in crontab I manage updates automatically

#! /bin/bash
NOW=$(date +"%F")
cd /home/1/Microsoft-Rewards-Script     #I place myself in the folder to check in

UPSTREAM=${1:-'@{u}'}
DIFFCOMM=$(git fetch origin --quiet; git rev-list HEAD..."$UPSTREAM" --count)
if [ "$DIFFCOMM" -gt 0 ]; then
  echo "Rebuild $UPSTREAM";

##############################commands to be executed if there is an update#######################################

else
  echo "è tutto aggiornato";
fi

@ChainDev162
Copy link
Author

this is my little contribution with this little script by putting it in crontab I manage updates automatically

#! /bin/bash
NOW=$(date +"%F")
cd /home/1/Microsoft-Rewards-Script     #I place myself in the folder to check in

UPSTREAM=${1:-'@{u}'}
DIFFCOMM=$(git fetch origin --quiet; git rev-list HEAD..."$UPSTREAM" --count)
if [ "$DIFFCOMM" -gt 0 ]; then
  echo "Rebuild $UPSTREAM";

##############################commands to be executed if there is an update#######################################

else
  echo "è tutto aggiornato";
fi

Line 3 isn't really well-suited, since people might not have a /home/l/ directory. Also, some people might have cloned this repository onto another directory (~/Documents/ for example), but overall this is a pretty good script! Thanks!

@basalisco
Copy link

this is my little contribution with this little script by putting it in crontab I manage updates automatically

#! /bin/bash
NOW=$(date +"%F")
cd /home/1/Microsoft-Rewards-Script     #I place myself in the folder to check in

UPSTREAM=${1:-'@{u}'}
DIFFCOMM=$(git fetch origin --quiet; git rev-list HEAD..."$UPSTREAM" --count)
if [ "$DIFFCOMM" -gt 0 ]; then
  echo "Rebuild $UPSTREAM";

##############################commands to be executed if there is an update#######################################

else
  echo "è tutto aggiornato";
fi

Line 3 isn't really well-suited, since people might not have a /home/l/ directory. Also, some people might have cloned this repository onto another directory (~/Documents/ for example), but overall this is a pretty good script! Thanks!

There is a comment alongside line 3. This is the base a starting point my I have customized with some commands that are executed only if there is an "upgrade" (commit)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants