Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix port forwarding bug on initial connection for ssh tunnel or possibly some slower connections. #27

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

alanxoc3
Copy link

@alanxoc3 alanxoc3 commented Dec 14, 2022

I could get multiplayer working on a local host, but as soon as I enabled port forwarding, clients wouldn't successfully connect to the server.

Ended up spending hours going through your codebase & the mgba scripting api and figured out the issue.

Btw, I think that code base could use some help. I wouldn't mind donating a few days to help out. Some things I think you could benefit from that I could help out with:

  • Better handling network errors (server/client shouldn't crash when there are problems...)
  • Format the code.
  • Have a configuration file instead of needing to specify configuration in the lua files.
  • Maybe have a file for shared code between client & server. (Have a build process, so you don't have to copy it into both files every time.)
  • Improved logging.

Ping me if you're interested. (I don't want to make big changes without coordinating.)

@TheHunterManX
Copy link
Owner

Thank you for your input and help. This is and will be accomplished in 3.5, which will be out this month. Except for the config file, which I don't believe is in the mgba documentation. Can you load additional files?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants