Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance: 75% faster Project Euler 187 #10503

Merged
merged 10 commits into from
Oct 15, 2023
Merged

Performance: 75% faster Project Euler 187 #10503

merged 10 commits into from
Oct 15, 2023

Conversation

ManpreetXSingh
Copy link
Contributor

@ManpreetXSingh ManpreetXSingh commented Oct 15, 2023 •
edited

Describe your change:

#8594

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeper algorithms-keeper bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Oct 15, 2023
@algorithms-keeper algorithms-keeper bot added tests are failing Do not merge until tests pass and removed tests are failing Do not merge until tests pass labels Oct 15, 2023
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Oct 15, 2023
@cclauss cclauss merged commit 1ebae5d into TheAlgorithms:master Oct 15, 2023
5 checks passed
@ManpreetXSingh ManpreetXSingh deleted the performance-project-euler-187 branch October 15, 2023 09:18
@ManpreetXSingh
Copy link
Contributor Author

ManpreetXSingh commented Oct 15, 2023 •
edited

HI @cclauss,
I noticed that there is another file with the same prime number generator algorithm that hasn't been optimized yet. prime_sieve_eratosthenes.py.
If you'd like, I can create a new pull request to optimize the prime number generator in the other file or assist with the process in any way you prefer. Just let me know how you'd like to proceed.
Thanks for your time and consideration!

@cclauss
Copy link
Member

cclauss commented Oct 15, 2023

Let's not mess with prime number generators -- we have tons of them.

@ManpreetXSingh ManpreetXSingh mentioned this pull request Oct 16, 2023
Open
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

Assignees
No one assigned
Labels
enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ManpreetXSingh @cclauss