Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE before adding the token] chore: update codecov-action to v4 #1605

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vil02
Copy link
Member

@vil02 vil02 commented Feb 2, 2024

Open in Gitpod know more

Describe your change:

Same as TheAlgorithms/Rust#670 - it contains the description of the problem.

Before merging, please add the token from https://app.codecov.io/gh/TheAlgorithms/JavaScript/settings as CODECOV_TOKEN into the repo secrets.

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.

@vil02 vil02 marked this pull request as ready for review February 2, 2024 18:42
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6aaa376) 82.44% compared to head (8176408) 82.44%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1605   +/-   ##
=======================================
  Coverage   82.44%   82.44%           
=======================================
  Files         377      377           
  Lines       19747    19747           
  Branches     2884     2885    +1     
=======================================
  Hits        16281    16281           
  Misses       3466     3466           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@appgurueu
Copy link
Collaborator

It seems that in order to add the token, I would have to be logged in (on the codecov site) to access https://app.codecov.io/gh/TheAlgorithms/JavaScript/settings ? I'm slightly uncomfortable with this as it requests permission to "act on my behalf":

Screenshot from 2024-02-02 20-47-06

@vil02
Copy link
Member Author

vil02 commented Feb 2, 2024

It seems that in order to add the token, I would have to be logged in (on the codecov site) to access https://app.codecov.io/gh/TheAlgorithms/JavaScript/settings ?

Yes.

I'm slightly uncomfortable with this as it requests permission to "act on my behalf":

I agree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants