Create GenerateSubsets #1581
Create GenerateSubsets #1581
Conversation
|
@imshreya2000 pls add tests and some documentation |
|
@CarlosZoft I have added the test and explanation. Kindly review. |
| @@ -0,0 +1,26 @@ | |||
| function generateSubsets(nums) { | |||
There was a problem hiding this comment.
- Call the parameter
arr, notnums. The implementation doesn't need to make any assumptions about the values inarr. - This should have a doc comment stating what this does (builds and returns a list of all subsets in lexicographic order). Also, consider using a generator rather than building a list; sometimes you want to iterate over all subsets without storing them all temporarily in memory (for example when solving hard optimization problems).
| function generateSubsets(nums) { | ||
| const subsets = []; | ||
|
|
||
| function backtrack(start = 0, currentSubset = []) { |
There was a problem hiding this comment.
I'm not sure I would call this backtracking; to me it's just ordinary recursion:
Backtracking is a class of algorithms for finding solutions to some computational problems, notably constraint satisfaction problems, that incrementally builds candidates to the solutions, and abandons a candidate as soon as it determines that the candidate cannot possibly be completed to a valid solution.
| return subsets; | ||
| } | ||
|
|
||
| const inputSet = [1, 2, 3]; |
There was a problem hiding this comment.
This example should be removed from this file (or converted into a JSDoc example).
| @@ -0,0 +1,24 @@ | |||
| // we define a generateSubsets function that uses backtracking to generate all possible subsets of a given set (array of numbers). The backtrack function is a recursive function that explores all possible subsets by considering or excluding each element. | |||
There was a problem hiding this comment.
That's in the other file. Remove this comment from the test file.
Describe your change:
Checklist:
Example:
UserProfile.jsis allowed butuserprofile.js,Userprofile.js,user-Profile.js,userProfile.jsare notFixes: #{$ISSUE_NO}.