Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test cases project euler #1575

Open
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

pomkarnath98
Copy link
Member

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in their comments that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@pomkarnath98
Copy link
Member Author

pomkarnath98 commented Oct 24, 2023

@appgurueu @raklaptudirm I have added the test cases for all the existing Project Euler problem solutions. All the remaining problems need to be solved which we'll be solving gradually.

Already created existing PRs for the Project Euler problems Problem 4, Problem 5, Problem 6, Problem 9 can be checked as well.

Kindly verify and merge the PRs, if looks good.

@pomkarnath98 pomkarnath98 mentioned this pull request Oct 25, 2023
11 tasks
Copy link
Member

@raklaptudirm raklaptudirm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pr seems to have lots of unrelated changes which should be removed.

import { latticePath } from '../Problem015.js'

describe('Lattice Paths', () => {
test('if grid size is 2', () => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Such repetitive tests should use test.each / it.each to reduce the boilerplate.

@mohmmadAyesh
Copy link

@appgurueu Hi I want to contribute to make the last request changes is this PR available ?

@appgurueu
Copy link
Collaborator

@mohmmadAyesh I think you'd have to ask @pomkarnath98 that.

@mohmmadAyesh
Copy link

@pomkarnath98 is this pull request still open can i contribute to continue suggested changes?

@pomkarnath98
Copy link
Member Author

pomkarnath98 commented Apr 8, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants