Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add tests for Eucledian GCD Algorithm #1540

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

malpotra
Copy link
Contributor

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in their comments that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

Copy link
Collaborator

@appgurueu appgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have Maths/GetEuclidGCD.js (iterative). The iterative version is strictly better than the recursive one (doesn't waste stack space; JS can not be trusted to do tail call optimization).

So, the iterative version in Recursive/EucledianGCD.js should be removed. I'm not sure whether the recursive version should be kept.

Either way, the tests for the GCD should not be duplicated. These functions (Maths/GetEuclidGCD.js & recursive GCD) solve the same problem - and with the same time complexity even - and thus should use the same tests.

@malpotra malpotra closed this Oct 20, 2023
@malpotra malpotra reopened this Oct 20, 2023
@appgurueu
Copy link
Collaborator

As said, I think the existing GCD tests should be reused (or the recursive function should be removed altogether, as it is strictly inferior).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants