Skip to content

refactor: TwoPointers #6374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 13, 2025
Merged

Conversation

alxkm
Copy link
Contributor

@alxkm alxkm commented Jul 12, 2025

  • Added a null check with an exception to fail fast if input is null. And test for this.
  • Made class public for usability.
  • Used clearer variable names (left and right) that are more descriptive than i and j.
  • Expanded Javadoc for parameters and exceptions.
  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized it.
  • All filenames are in PascalCase.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
  • All new code is formatted with clang-format -i --style=file path/to/your/file.java

@codecov-commenter
Copy link

codecov-commenter commented Jul 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.64%. Comparing base (182118b) to head (b17567a).

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #6374   +/-   ##
=========================================
  Coverage     74.63%   74.64%           
- Complexity     5443     5445    +2     
=========================================
  Files           682      682           
  Lines         18998    19000    +2     
  Branches       3668     3668           
=========================================
+ Hits          14179    14182    +3     
  Misses         4260     4260           
+ Partials        559      558    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@DenizAltunkapan DenizAltunkapan enabled auto-merge (squash) July 13, 2025 09:23
@DenizAltunkapan DenizAltunkapan merged commit ef93cc1 into TheAlgorithms:master Jul 13, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants