Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Trapped Rain Water using Dynamic Programming Strategy. #2688

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Implement Trapped Rain Water using Dynamic Programming Strategy. #2688

wants to merge 4 commits into from

Conversation

TruongNhanNguyen
Copy link

Checklist

  • Added description of change
  • Added file name matches File name guidelines
  • Added tests and example, test must pass
  • Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

@TruongNhanNguyen
Copy link
Author

Let's take a look on this PR @realstealthninja & @Panquesito7

mrmagic2020
mrmagic2020 reviewed Apr 28, 2024
View reviewed changes
Copy link

@mrmagic2020 mrmagic2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks pretty solid and is well-documented. Not sure if modification of DIRECTORY.md is needed. What do you think @realstealthninja?

DIRECTORY.md Outdated Show resolved Hide resolved
dynamic_programming/trapped_rainwater.cpp Outdated Show resolved Hide resolved
mrmagic2020
mrmagic2020 approved these changes Apr 30, 2024
View reviewed changes
Copy link

@mrmagic2020 mrmagic2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrmagic2020 mrmagic2020 mrmagic2020 approved these changes

@Panquesito7 Panquesito7 Awaiting requested review from Panquesito7 Panquesito7 is a code owner

@realstealthninja realstealthninja Awaiting requested review from realstealthninja realstealthninja is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TruongNhanNguyen @mrmagic2020