Open
Conversation
Fix the app display not refreshing after `action_suspend_process`. A similar issue was reported in Textualize#5528 but specifically when using the `App.suspend` context manager. This was fixed in 81392ff by adding `refresh(layout=True)`, however this doesn't cover when the app was suspended with `action_suspend_process`. This simply moves that call to `refresh` to account for both suspend methods. Related issue: Textualize#6298
Member
|
Can we have a test for this? |
Collaborator
Author
|
Is it actually possible to test for this that involves suspending and resuming the app? |
Member
|
There is Maybe that can be extended with a simple check that refresh was called at the expected point? |
Collaborator
Author
|
I had a look at the existing tests but they don't cover |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the app display not refreshing after
action_suspend_process.A similar issue was reported in #5528 but specifically when using the
App.suspendcontext manager. This was fixed in 81392ff by addingrefresh(layout=True), however this doesn't cover when the app was suspended withaction_suspend_process. This simply moves that call torefreshto account for both suspend methods.Related issue: #6298