Fix sharing when using initfile. #7727
Open
+11
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
niktayv
reviewed
Nov 15, 2025
| ) { | ||
| const uri = new URI(document.baseURI).fragment("").search(""); | ||
|
|
||
| const usefulSubs = new URL(document.URL).hash |
Collaborator
There was a problem hiding this comment.
Can we find a more descriptive name for this variable?
Collaborator
|
It would be helpful to describe how to test this feature. |
Collaborator
|
By the way, I inspected the CI/build failure that occurs at |
Contributor
Author
|
Updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Fixes #7269
Replace PR #7270
Test me
Using, ie,
https://terriamap.com/#emg202305, you can load some data fromemg202305.json.Without this fix, the sharing link from
https://terriamap.com/#emg202305will be something likehttps://terriamap.com/#share=g-8feface8fefd6fe09ac81f22f21ec5d8
so you can't reload data from
emg202305.json.Instead, with this fix, the link will be something like
https://terriamap.com/#emg202305&share=g-8feface8fefd6fe09ac81f22f21ec5d8
Checklist
doc/.